Add North Dakota renter's refund#8314
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8314 +/- ##
============================================
+ Coverage 78.70% 100.00% +21.29%
============================================
Files 4750 4 -4746
Lines 69270 52 -69218
Branches 341 0 -341
============================================
- Hits 54517 52 -54465
+ Misses 14675 0 -14675
+ Partials 78 0 -78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Program Review (read-only audit)Source Documents
Critical (Must Fix)
Should Address
Suggestions
PDF Audit Summary
Confirmed correct: Mismatches rejected (code-path cleared): Unmodeled items (out-of-scope or known limitations): one-refund-per-household rule (§ 57-02-08.1(2)(c)), June 1 filing deadline, deceased-applicant estate filing, utilities-in-rent offset (Form 24757 lines 2a-2d), mobile-home-on-rented-lot exception. Validation Summary
Review Severity: REQUEST_CHANGESThe 5 confirmed criticals (2 date-history gaps + 3 income-source list entries) are all backed by primary-source statutory or guideline text. The SSI question is ambiguous in the statute and should be resolved one way or the other by the author. Review generated by |
hua7450
left a comment
There was a problem hiding this comment.
Requesting changes based on the full review in this comment.
5 critical (must fix):
income_limit.yaml— effective date should be2023-01-01: 70_000(HB 1158), with<earlier>: 42_000for the prior era.cap.yaml— add2009-01-01: 400before the2025-01-01: 600entry.- Remove
child_support_receivedfromincome_sources.yaml(Guideline 24887 Item 11 exclusion). - Remove
survivor_benefitsfromincome_sources.yaml(workers-comp survivor — Guideline Item 11). - Remove
financial_assistancefromincome_sources.yaml(gifts/inheritance — Guideline Item 11 + IRC §102).
Plus one statutory ambiguity to resolve (ssi) and 15 should-address items in the full review comment.
Summary
Closes #8199.
Homeowner follow-up: #8325 tracks the separate North Dakota Homestead Property Tax Credit model.
Value Review
Modeling Notes
adjusted_gross_incomeas the closest available proxy for the program's income-from-all-sources measure after eligible medical expense deductions.rentas eligible rent, assuming it excludes utilities, furniture, garage rent, federal rent subsidy, and rent paid for property-tax-exempt quarters.is_permanently_and_totally_disabledfor the disability eligibility path.Sources:
Tests
/Users/daphnehansell/Documents/GitHub/policyengine-us/.venv/bin/ruff check policyengine_us/variables/gov/states/nd/tax/property/renters_refund policyengine_us/tests/policy/baseline/gov/states/nd/tax/property/renters_refund/Users/daphnehansell/Documents/GitHub/policyengine-us/.venv/bin/python -m policyengine_core.scripts.policyengine_command test policyengine_us/tests/policy/baseline/gov/states/nd/tax/property/renters_refund -c policyengine_us/Users/daphnehansell/Documents/GitHub/policyengine-us/.venv/bin/python -m pytest policyengine_us/tests/test_parameter_files.py policyengine_us/tests/test_system_import.py -q